Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sublist items in columns (#70) #74

Merged
merged 1 commit into from
Sep 5, 2023
Merged

fix: sublist items in columns (#70) #74

merged 1 commit into from
Sep 5, 2023

Conversation

andrew-polk
Copy link
Contributor

@andrew-polk andrew-polk commented Aug 29, 2023

Also improves numbered lists by numbering them sequentially


This change is Reviewable

@stackblitz
Copy link

stackblitz bot commented Aug 29, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Member

@hatton hatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 9 of 9 files at r1.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @andrew-polk)

Copy link
Member

@hatton hatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @andrew-polk)


src/pull.ts line 378 at r1 (raw file):

// They always run it on the results of their getBlockChildren.
// When we use our own getBlockChildren, we need to run it too.
function enumerateIfNumberedList(

I suggest "numberChildrenIfNumberedList()"

Also improves numbered lists by numbering them sequentially
Copy link
Contributor Author

@andrew-polk andrew-polk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 7 of 11 files reviewed, 1 unresolved discussion (waiting on @hatton)


src/pull.ts line 378 at r1 (raw file):

Previously, hatton (John Hatton) wrote…

I suggest "numberChildrenIfNumberedList()"

Done.

Copy link
Member

@hatton hatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @andrew-polk)

@hatton hatton merged commit 75500d7 into main Sep 5, 2023
2 checks passed
@github-actions
Copy link

github-actions bot commented Sep 5, 2023

🎉 This PR is included in version 0.14.0-alpha.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 0.14.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants