-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix reusing project-codes gets 404/undefined from GQL cache #1084
Fix reusing project-codes gets 404/undefined from GQL cache #1084
Conversation
UI unit Tests12 tests 12 ✅ 0s ⏱️ Results for commit 493018d. ♻️ This comment has been updated with latest results. |
0064af5
to
82162c7
Compare
@hahn-kev You were right, of course 😉. I was totally on the wrong track. I didn't realize that we were excpliticly caching null. I ended up adding 2 fixes...either one would actually fix this specific error. The reason I included both is:
|
I want to get this merged since we have people actively seeing this error. But I also want to have an automated test for this since we've had project deletion broken before. Do you want to do it in this PR or another one? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just one minor request, feel free to merge it then.
a6e6815
to
493018d
Compare
Fixes #1051
It does actually seem to be the case that GQL caching was the problem here (even though I bumped into some weird behaviour in our awaitedQueryStore that I thought was the root of the issue).
I've opened a discussion In the hopes of finding a slightly more elegant solution, but I'm doubtful 🤷. So, for details see that discussion or the many comments in this PR.
There are several bonus fixes in this PR: