SF-2997 Refresh training books on step change

[josephmyers]

This is currently baselined off SF-2973 but will be updated once that PR is in.

---

This change is 

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.02%. Comparing base (76f27a1) to head (a1160eb).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2763      +/-   ##
==========================================
- Coverage   79.02%   79.02%   -0.01%     
==========================================
  Files         530      530              
  Lines       30719    30719              
  Branches     5021     5016       -5     
==========================================
- Hits        24276    24275       -1     
  Misses       5661     5661              
- Partials      782      783       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[pmachapman]

Is it possible to have a unit test that recreate the scenario by mimicking the clicks? Your fix does stop the bug occurring, but my concern is there is no way to test for regressions.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @josephmyers)

---

src/SIL.XForge.Scripture/ClientApp/src/app/translate/draft-generation/draft-generation-steps/draft-generation-steps.component.html line 8 at r1 (raw file):

      labelPosition="bottom"
      [disableRipple]="true"
      (selectionChange)="updateTrainingBooks()"

It feels kind of wrong to have two event handler attributes with the same name.

Are you able to update onStepChange() to call updateTrainingBooks() instead of having two selectionChange attributes?

Code quote:

      (selectionChange)="onStepChange()"
      labelPosition="bottom"
      [disableRipple]="true"
      (selectionChange)="updateTrainingBooks()"

[josephmyers]

Thanks. Last week I was thinking it'd be not worth the time to test the clicking specifically, since there's already coverage for the function itself, but today I realized it was actually quite doable.

Reviewable status: 0 of 75 files reviewed, 1 unresolved discussion (waiting on @pmachapman)

---

src/SIL.XForge.Scripture/ClientApp/src/app/translate/draft-generation/draft-generation-steps/draft-generation-steps.component.html line 8 at r1 (raw file):

Previously, pmachapman (Peter Chapman) wrote…

It feels kind of wrong to have two event handler attributes with the same name.

Are you able to update onStepChange() to call updateTrainingBooks() instead of having two selectionChange attributes?

Yeah I saw that today. Ooops!

[pmachapman]

Reviewed 2 of 75 files at r2, 67 of 67 files at r3, 6 of 6 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @josephmyers)