Fix language picker font not being used #2802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2802 +/- ##
=======================================
Coverage 79.02% 79.02%
=======================================
Files 530 530
Lines 30719 30719
Branches 5022 5017 -5
=======================================
Hits 24275 24275
Misses 5661 5661
Partials 783 783 ☔ View full report in Codecov by Sentry. |
pmachapman
force-pushed
the
fix/use-font-picker-font
branch
from
c0f1066
to
6fc3384
Compare
pmachapman
approved these changes
Oct 14, 2024
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Nateowami)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The font picker was not actually being used because Material has a rule that directly applied to
.mat-mdc-menu-item-text, and our rule only applied it to.mat-mdc-menu-item(the parent element).You can tell what font is being used by going to the "computed" tab of the element inspector and scrolling to the bottom. You can also look at the network tab and filter for fonts, and see that the language picker font wasn't even being loaded.
I also removed
(W. Kayah Li)because the text was originally added in #594 for font reasons.Please note that not all locale names are being rendered with the language picker font, because we haven't been updating the language picker font. However, it does have the Western Kayah Li font, so I feel comfortable removing the English.
This change is