Fix SemaphoreFullException from incorrect use of SemaphoreSlim #2803
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes
SemaphoreFullException
crashes that have been occurring on sync, dueReleaseAsync()
being called beforeWaitAsync()
had completed. This can happen if the token is cancelled.The solution to this is to follow the correct design pattern by having
WaitAsync()
called before try/catch block.This PR does not require testing, as the only confirmation necessary is that a sync is successful.
This change is