Fix SemaphoreFullException from incorrect use of SemaphoreSlim #2803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nateowami
approved these changes
Oct 14, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @pmachapman)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2803 +/- ##
=======================================
Coverage 79.02% 79.02%
=======================================
Files 530 530
Lines 30719 30719
Branches 5021 5022 +1
=======================================
Hits 24276 24276
- Misses 5661 5673 +12
+ Partials 782 770 -12 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes
SemaphoreFullExceptioncrashes that have been occurring on sync, dueReleaseAsync()being called beforeWaitAsync()had completed. This can happen if the token is cancelled.The solution to this is to follow the correct design pattern by having
WaitAsync()called before try/catch block.This PR does not require testing, as the only confirmation necessary is that a sync is successful.
This change is