Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all translation files from Crowdin #2824

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Update all translation files from Crowdin #2824

merged 1 commit into from
Oct 28, 2024

Conversation

Nateowami
Copy link
Collaborator

@Nateowami Nateowami commented Oct 26, 2024

This change is Reviewable

Copy link

codecov bot commented Oct 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.10%. Comparing base (4d8914a) to head (b276e0a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2824      +/-   ##
==========================================
- Coverage   79.10%   79.10%   -0.01%     
==========================================
  Files         531      531              
  Lines       30859    30859              
  Branches     5016     5038      +22     
==========================================
- Hits        24411    24410       -1     
  Misses       5674     5674              
- Partials      774      775       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@josephmyers josephmyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Nateowami)

@josephmyers josephmyers self-assigned this Oct 28, 2024
@josephmyers
Copy link
Collaborator

It's a little suspicious that Chromatic registers a UI change (it's not localization related). This is probably some unreliability with Chromatic, but I'm not certain. Approving anyway

@josephmyers josephmyers merged commit 55332a6 into master Oct 28, 2024
15 checks passed
@josephmyers josephmyers deleted the i18n/update branch October 28, 2024 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants