Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Node 20.12.2 #179

Merged

Conversation

joshuacurtiss
Copy link
Contributor

Upgraded the project to Node 20.12.2, including its GitHub Actions job.

This supersedes #178, please see additional notes there that were taken into consideration in this PR.

Tim Addai and others added 6 commits August 23, 2024 22:27
Upgrading grunt-contrib-uglify to 5.2.2 ensures that we're consistently
using a modern version of Uglify that can handle modern syntax.
Fixed uglify configurations to change based on whether we are in debug mode or not.
The CI steps need to be updated to use Node 20. While doing so, we incorporate some
additional work:

- Update all actions to use the latest versions that run on Node 20
- Update test matrix to use our .nvmrc file as one of the Node versions to test against
- Check for uncommitted changes after installing dependencies
@coveralls
Copy link

Coverage Status

coverage: 18.386%. remained the same
when pulling 981f9ab on joshuacurtiss:jcurtiss/upgrade-node-20.12.2
into 718c832 on silvermine:master.

@onebytegone onebytegone merged commit 0f83898 into silvermine:master Aug 26, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants