Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated documentation #271

Merged
merged 2 commits into from
Sep 7, 2023
Merged

Updated documentation #271

merged 2 commits into from
Sep 7, 2023

Conversation

t20100
Copy link
Member

@t20100 t20100 commented Sep 4, 2023

Small update to fix layout of list in sphinx documentation and update readthedoc configuration that's using an obsolete parameter

@t20100 t20100 added this to the Next release milestone Sep 4, 2023
@t20100 t20100 requested a review from vasole September 4, 2023 10:04
@t20100
Copy link
Member Author

t20100 commented Sep 4, 2023

CI fails on macos with Python3.7 because it now produces a macosx_11_7_x86_64.whl wheel while in produced a macosx_10_15_x86_64.whl last time it run....

ERROR: hdf5plugin-4.1.3-py3-none-macosx_11_7_x86_64.whl is not a supported wheel on this platform

Something has changed and MACOSX_DEPLOYMENT_TARGET no longer seems to be taken into account:
wheel and setuptools has been updated in the meantime (and setuptools dropped python3.7 along the way), also macOS version changed from 12.6.5 to 12.6.7...

@t20100 t20100 requested a review from kif September 4, 2023 12:48
@t20100
Copy link
Member Author

t20100 commented Sep 4, 2023

PR #275 fixes the CI.

@kif
Copy link
Member

kif commented Sep 5, 2023

RTD is not part of the CI ... it should not be too complicated to integrate it...

@t20100
Copy link
Member Author

t20100 commented Sep 5, 2023

RTD is set-up through a github webhook, last PR merged triggered a build: https://readthedocs.org/projects/hdf5plugin/builds/

Copy link
Member

@kif kif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kif kif merged commit 050f225 into main Sep 7, 2023
5 of 6 checks passed
@t20100 t20100 deleted the doc branch September 7, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants