Upgrade H5Web and fix error display when file size limit is reached #40
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading H5Web to v11.2.0 and fixing an issue with the file-size limit error not appearing (it was thrown outside of the error boundary).
Unfortunately, I don't think I can switch to
H5WasmLocalFileProvider
to remove the file size limit altogether. When I open an HDF5 file in VS Code, I get aCustomDocument
with a URI. I can convert this URI into one that the webview can fetch, but I can't pass a reference to the underlying file on the file system.In the webview,
H5WasmLocalFileProvider
needs aFile
object from an HTML file input. I can probably fake it by creating aFile
object from aBlob
withnew File([blob], 'name')
, but to create thatBlob
I need anArrayBuffer
, so I still end up having to fetch the file even though it's local.Shame... Maybe it will work once I implement a provider that can do range requests.