Upgrade H5Web and fix error display when file size limit is reached #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loichuder
approved these changes
Apr 19, 2024
There was a problem hiding this comment.
Unfortunate. I guess there is no way around it:
Webviews run in isolated contexts that cannot directly access local resources.
https://code.visualstudio.com/api/extension-guides/webview#loading-local-content
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading H5Web to v11.2.0 and fixing an issue with the file-size limit error not appearing (it was thrown outside of the error boundary).
Unfortunately, I don't think I can switch to
H5WasmLocalFileProviderto remove the file size limit altogether. When I open an HDF5 file in VS Code, I get aCustomDocumentwith a URI. I can convert this URI into one that the webview can fetch, but I can't pass a reference to the underlying file on the file system.In the webview,
H5WasmLocalFileProviderneeds aFileobject from an HTML file input. I can probably fake it by creating aFileobject from aBlobwithnew File([blob], 'name'), but to create thatBlobI need anArrayBuffer, so I still end up having to fetch the file even though it's local.Shame... Maybe it will work once I implement a provider that can do range requests.