Fix broken links on docs site #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @sortbyfirstname ! I need to learn what is up with those paths/urls, I was quite new with Astro and I found some weirdness with local/deployed versions myself (re: paths) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes some issues with broken links on the docs site, resolving #118.
The pips and range links in the sidebar were not navigating to their respective props in the article because the ids used were also being used in the SVG logo in the site header. When scrolling to fragment it was appearing to do nothing as this is at the top of the page. To resolve this, I have added a 'logo-' prefix to all element ids in all logo SVGs (for consistency).
The links on the Examples & Recipes pages were broken due to the path being incorrect. I have corrected these paths to resolve this.
The broken images on the Recipes page were due to both the way Astro handles public directory images and the way dynamic filename props work in Astro/Vite. The resolution for this is to remove public from the source, replacing with the base (svelte-range-slider-pips), and hardcoding the file extension.