use Uint8List instead of List<int> #37
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simolus3
reviewed
May 26, 2021
| @@ -69,6 +69,8 @@ extension ValueUtils on Pointer<sqlite3_value> { | |||
| } | |||
| } | |||
|
|
|||
| final utf8Encode = utf8.encoder.convert; | |||
There was a problem hiding this comment.
I think we should only define this once, the usage in memory.dart can just import this one.
simolus3
reviewed
May 26, 2021
sqlite3/lib/src/api/functions.dart
Outdated
| @@ -3,7 +3,7 @@ import 'package:meta/meta.dart'; | |||
| /// A scalar function exposed to sql. | |||
| /// | |||
| /// {@template sqlite3_function_behavior} | |||
| /// The function must either return a `bool`, `num`, `String`, `List<int>` or | |||
| /// The function must either return a `bool`, `num`, `String`, `Uint8List` or | |||
There was a problem hiding this comment.
I don't think we should force users to return a Uint8List here. It's a breaking change which IMO is not necessary. Most users return a Uint8List already, I don't see much value in an enforcement in the type system.
We can check if we got an Uint8List and implicitly copy to an Uint8List if we didn't.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#36