Skip to content

Commit

Permalink
removed String Terminator in base64_decode
Browse files Browse the repository at this point in the history
String Terminator was a verry bad Idea, because it causes an Overflow in decoding the MD5 Sum and writing String Terminators in the executed Flash by an OTA Update
see PhracturedBlue#67
  • Loading branch information
simone1999 authored Jul 26, 2019
1 parent 3745054 commit aea8b07
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/Base64.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ int base64_decode(char * output, const char * input, int inputLen) {
output[decLen++] = a3[j];
}
}
output[decLen] = '\0';
//output[decLen] = '\0'; was a verry bad Idea, because it causes an Overflow in decoding the MD5 Sum and writing String Terminators in the executed Flash by an OTA Update
return decLen;
}

Expand Down

0 comments on commit aea8b07

Please sign in to comment.