Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change stream trigger to FileWriter:IsOpen #22

Merged
merged 1 commit into from
May 11, 2021
Merged

Conversation

jlashner
Copy link
Collaborator

When testing on k2so, I realized that there were a number of bugs coming from the fact that pysmurf only records data when FileWriter:IsOpen is set to True. We were recording all data being streamed (with S.set_stream_enable(1)), was causing a few issues:

This PR changes the stream-trigger to the FileWriter:IsOpen variable instead of the enableStreaming, and doesn't allow data to be written to disk before this is set, which should prevent these cases from happening.

The FileWriter variables must be added to the metadata file in order for these to be processed by the session manager. See here: https://github.com/simonsobs/ocs-site-configs/blob/master/ucsd/k2so/smurf-srv14/meta_registers.yaml
Setting a regular polling interval here will make it so that we don't miss too much data even in the unlikely event where the FileWriter status update is dropped.

@jlashner jlashner merged commit 80a9188 into master May 11, 2021
@jlashner jlashner deleted the local-g3-bugfixes branch May 11, 2021 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants