Change stream trigger to FileWriter:IsOpen #22
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing on k2so, I realized that there were a number of bugs coming from the fact that pysmurf only records data when FileWriter:IsOpen is set to True. We were recording all data being streamed (with
S.set_stream_enable(1)
), was causing a few issues:This PR changes the stream-trigger to the FileWriter:IsOpen variable instead of the
enableStreaming
, and doesn't allow data to be written to disk before this is set, which should prevent these cases from happening.The FileWriter variables must be added to the metadata file in order for these to be processed by the session manager. See here: https://github.com/simonsobs/ocs-site-configs/blob/master/ucsd/k2so/smurf-srv14/meta_registers.yaml
Setting a regular polling interval here will make it so that we don't miss too much data even in the unlikely event where the FileWriter status update is dropped.