Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restart() was improperly declared with arguments #437

Merged
merged 7 commits into from
Jan 14, 2024
Merged

restart() was improperly declared with arguments #437

merged 7 commits into from
Jan 14, 2024

Conversation

simsong
Copy link
Owner

@simsong simsong commented Jan 14, 2024

Closes #436

Copy link

codecov bot commented Jan 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (92b29c3) 48.03% compared to head (724bc63) 48.73%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #437      +/-   ##
==========================================
+ Coverage   48.03%   48.73%   +0.70%     
==========================================
  Files         112      112              
  Lines       13240    13050     -190     
==========================================
  Hits         6359     6359              
+ Misses       6881     6691     -190     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simsong simsong merged commit 3eb2a98 into main Jan 14, 2024
11 checks passed
@simsong simsong deleted the fix-shadow branch January 14, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix shadowing issue in #433
1 participant