Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TDL-26703: Refactor the tap #113

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

prijendev
Copy link

@prijendev prijendev commented Nov 18, 2024

Description of change

  • Remove support of tap-framework python library.
  • Update the data type for the required fields.
  • Add missing fields into the schema of the respective streams
  • In the state, write the maximum replication value as a bookmark.
    • Also, write a bookmark with the respective replication key.
  • Keep a lookback window of 2min.

Manual QA steps

  • Run the discover mode and check the generated catalog.
  • Run the sync mode without state and verify records and state.
  • Run the sync mode with state and verify records and state.
  • Verify that sync mode follows the lookback window of 2mins.
  • Verify that tap extracts the deleted records when the parameter is provided in the configuration.

Risks

Rollback steps

  • revert this branch

AI generated code

https://internal.qlik.dev/general/ways-of-working/code-reviews/#guidelines-for-ai-generated-code

  • this PR has been written with the help of GitHub Copilot or another generative AI tool

@prijendev prijendev marked this pull request as ready for review November 19, 2024 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant