Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gen 349 #42

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

Gen 349 #42

wants to merge 22 commits into from

Conversation

cb-nandita
Copy link

@cb-nandita cb-nandita commented Apr 6, 2021

Description of change

  • Added support for Item Model
  • Added support for Multi-decimal (for Plan Model)
  • Added support for Account hierarchy (for Plan Model)
  • Organized the folder structure :
    a. common(common schemas to both plan model and item model)
    b. item_model
    c. plan_model
  • Introduced two types of streams : ITEM_MODEL_AVAILABLE_STREAMS, PLAN_MODEL_AVAILABLE_STREAMS
  • An API call will be made to Chargebee (/configurations) to check whether the merchant is in Plan model or Item model
  • Introduced a small change in sync logic, where the sync happens until 2 mins(i.e., sync_interval_in_mins) before current time
  • Added sort_by[ASC] parameter to all the API calls(wherever, available)

Manual QA steps

Risks

  • When a customer moves from plan model to item model in Chargebee, it automatically gets reflected in tap-chargebee sync flow, i.e, the tap will start creating and syncing to item model related tables

Rollback steps

  • revert this branch
  • Tables/columns created in third-party should be removed

@cmerrick
Copy link

cmerrick commented Apr 6, 2021

Hi @cb-nandita, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

@cmerrick
Copy link

You did it @cb-nandita!

Thank you for signing the Singer Contribution License Agreement.

Copy link

@loris-av loris-av left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants