Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tap-hubspot, as it is now, generates a schema with 2 types for integer fields, which is not allowed in a Postgres database (a column must have a single data type) and will make the postgres target (or any other relational databases targets) to generate 2 columns with different types and different names.
In this pull request I add a new argument that can be passed to the tap
--postgres_compatible
which will make the tap replace N/A values with None and generate a schema that will contain"type":[ "null", "number" ]
for integer fields, not"type":[ "null", "number" , "string"]
, as it happens in the current version. Otherwise, if the--postgres_compatible
argument is not passed, the schema that is generated will remain the same as it is at the moment.This is an alternative to #85