Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If a user has multiple roles that are able to find databases then the… #51

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

If a user has multiple roles that are able to find databases then the… #51

wants to merge 2 commits into from

Conversation

nathan5280
Copy link
Contributor

… database was returned in the list multiple times.

This patch removes duplicates instances of the data base from the list of discovered databases.

Description of change

remove duplicates from list of db names.

db_names = list(set(db_names))

# QA steps
 - [ ] automated tests passing
 - [ X] manual qa steps passing (list below)
       Ran locally to verify that the catalog only contained a single entry for the stream.
 
# Risks

# Rollback steps
 - revert this branch

… database was returned in the list multiple times.

This patch removes duplicates instances of the data base from the list of discovered databases.
@cmerrick
Copy link

Hi @nathan5280, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

@cmerrick
Copy link

You did it @nathan5280!

Thank you for signing the Singer Contribution License Agreement.

@jacobrobertbaca jacobrobertbaca mentioned this pull request Mar 11, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants