TDL-20215: Add missing integration tests #42
Conversation
tests/test_sftp_all_fields.py
Outdated
| expected_all_keys = stream_to_all_catalog_fields[stream] | ||
|
|
||
| # Tap is not writing _sdc_extra so removing it from expected keys. | ||
| expected_all_keys = expected_all_keys - {"_sdc_extra"} |
There was a problem hiding this comment.
We can get _sdc_extra if we override generate_simple_csv_lines_typeA and send extra field data for one or two rows.
There was a problem hiding this comment.
Overrided generate_simple_csv_lines_typeA() function, and generated data for sdc_extra field.
tests/test_sftp_automatic.py
Outdated
| def name(self): | ||
| return "tap_tester_sftp_automatic_fields" | ||
|
|
||
| def get_files(self): |
There was a problem hiding this comment.
It seems duplicating can we move this to base.py?
There was a problem hiding this comment.
Yes, Moved get_files() to base for the most used common structure, and override in other files if requires.
| } | ||
| ] | ||
|
|
||
| def setUp(self): |
There was a problem hiding this comment.
Add function comments for each file's function.
There was a problem hiding this comment.
Added function comments
tests/test_sftp_automatic.py
Outdated
| ] | ||
|
|
||
| def setUp(self): | ||
| if not all([x for x in [os.getenv('TAP_SFTP_USERNAME'), |
There was a problem hiding this comment.
Setup is also used in many files so move this to base.py and for diff lines, use super and add those lines.
There was a problem hiding this comment.
The SetUp() function is related to pytest so it will require in each file to set up something before running that particular test.
Description of change
TDL-20215: Add missing integration tests
Manual QA steps
Risks
Rollback steps