Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce support for end_date parameter #181

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

OSalama
Copy link

@OSalama OSalama commented Oct 1, 2023

Description of change

Introduce support for an end_date parameter
which can be used to control the sync's stop_time.

This is intended to be used to pull back
date ranges that have historically not
been ingested, without needing to sync
all data. For example, if you are missing
data from 2023-01-01 to 2023-02-01,
you could set the start and end dates
to these values to retrieve just that
month of data, rather than potentially
syncing an extra 9 months of data.
This can also be used to incrementally
test your ELT workflows to ensure they
are compatible with older data schemas.
Also requested by #72

QA steps

  • automated tests passing
  • manual qa steps passing (list below)
    • Add start_date = 2 days ago, end_date = 1 day ago to config and manually run a sync on orders stream . Ensure no API requests are made for today's date.

Risks

Rollback steps

  • revert this branch

This is intended to be used to pull back
date ranges that have historically not
been ingested, without needing to sync
all data. For example, if you are missing
data from 2023-01-01 to 2023-02-01,
you could set the start and end dates
to these values to retrieve just that
month of data, rather than potentially
syncing an extra 9 months of data.
This can also be used to incrementally
test your ELT workflows to ensure they
are compatible with older data schemas.
@singer-bot
Copy link

Hi @OSalama, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

@singer-bot
Copy link

You did it @OSalama!

Thank you for signing the Singer Contribution License Agreement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants