Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix thread_ts values in messages and threads streams #12

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix thread_ts values in messages and threads streams #12

wants to merge 2 commits into from

Conversation

koszti
Copy link

@koszti koszti commented Oct 5, 2020 •
edited
Loading

Description of change

Cannot join messages and threads tables because thread_ts column not populated correctly.

Manual QA steps

messages.thread_ts should be populated by conversations.history API endpoint and threads.thread_ts should be populated by conversations.replies endpoint

Risks

Rollback steps

  • revert this branch

@jacobphillips1020
Copy link

Hey all! Can someone merge this commit? Without it it's impossible to associate a thread with a parent message! Thank you :)

@egwoo
Copy link

egwoo commented Sep 20, 2023

Bumping this PR as we're running into the same issue

@kogre
Copy link

kogre commented Oct 17, 2023

Bumping this once more as we're also running into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egwoo egwoo egwoo approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@koszti @jacobphillips1020 @egwoo @kogre @luandy64