Add bookmarking and new streams to Slack Tap #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run on Circle without private Docker image
By default, we will still get private channels. This requires the extra `groups:` scopes. Previously, even if we didn't want to sync private groups, the calls to the Slack API would fail as the calls we made defined the types as `"public_channel,private_channel"`. There is now an optional config, `private_channels`, that allows the user to disable private channels in the config file. Also added documentation for the config file.
Allow user to disable private channels
Allow user to specify specific channels
- Files - Remote Files - Threads - User Groups - Teams Updated Streams: - Channels - Channel Members - Messages * Adopted a parent/child stream relationship for Messages and Threads. * Added bookmarking for all Incremental Streams.
* Added basic tap tester framework * Changed circle yml to reflect tap tester framework * More documentation
* Public Channel Auto-Join now only joins channels that are specified if a channel list is provided via the config.
Major Slack Tap Changes
KAllan357
suggested changes
Jul 10, 2020
.circleci/config.yml
Outdated
| steps: | ||
| - checkout | ||
| - run: | ||
| name: 'Setup virtual env' | ||
| command: | | ||
| /root/.pyenv/versions/3.6.9/bin/python -mvenv /usr/local/share/virtualenvs/tap-slack | ||
| python3 -mvenv /usr/local/share/virtualenvs/tap-slack |
There was a problem hiding this comment.
Suggested change
| python3 -mvenv /usr/local/share/virtualenvs/tap-slack | |
| pyenv global 3.6.9 | |
| pyenv rehash | |
| python3 -mvenv /usr/local/share/virtualenvs/tap-slack |
* Fix circleci yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
(write a short description or paste a link to JIRA)
Added several new Slack API endpoints, implemented bookmarking.
Manual QA steps
Risks
Rollback steps
Rollback steps