Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'description' and 'default' fields to 'groups' schema #54

Open
wants to merge 2 commits into
base: add_description_default_to_groups_schema
Choose a base branch
from
Open

Add 'description' and 'default' fields to 'groups' schema #54

wants to merge 2 commits into from

Conversation

BenjMaq
Copy link

@BenjMaq BenjMaq commented Feb 3, 2021

Description of change

default and description are two fields available in the Zendesk Support API for the groups entity.
They are currently not available in the tap-zendesk schema for groups. This PR is adding them.

Manual QA steps

  • Ran tap-zendesk locally
WARNING Removed 2 paths during transforms:
    default
    description
WARNING Removed paths list: ['default', 'description']
  • Ran tap-zendesk with branch add_description_default_to_groups_schema locally
    -> No WARNING. All fields, including default and description have been pulled.

Risks

  • Very low.

Rollback steps

  • Revert this branch

@BenjMaq BenjMaq changed the title Add description default to groups schema Add 'description' and 'default' fields to 'groups' schema Feb 3, 2021
@somethingmorerelevant somethingmorerelevant changed the base branch from master to add_description_default_to_groups_schema October 18, 2022 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant