Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] NumPy 2 experiment [WIP] #2934

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[python] NumPy 2 experiment [WIP] #2934

wants to merge 1 commit into from

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Aug 27, 2024

Issue and/or context: #2536

Changes:

Notes for Reviewer:

Main thing to watch for: NumPy 2.0 does not support Python 3.8, while we have not yet dropped support for Python 3.8 (#2141).

Per https://github.com/numpy/numpy/releases/tag/v2.0.0:

The Python versions supported by this release are 3.9-3.12.

I thought we'd need a bit in setup.py like

        # There is no Python 3.8 support for NumPy 2
        "numpy<2; python_version<'3.9'",
        "numpy; python_version>='3.9'",

but in hindsight it seems not -- a Python 3.8 asking to get NumPy will simply not be offered version 2 in the first place 😎

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.02%. Comparing base (56f3b42) to head (441dae6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2934      +/-   ##
==========================================
+ Coverage   89.87%   90.02%   +0.15%     
==========================================
  Files          38       38              
  Lines        3999     3999              
==========================================
+ Hits         3594     3600       +6     
+ Misses        405      399       -6     
Flag Coverage Δ
python 90.02% <ø> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 90.02% <ø> (+0.15%) ⬆️
libtiledbsoma ∅ <ø> (∅)

@johnkerl
Copy link
Member Author

johnkerl commented Aug 27, 2024

Oddly, the "Show package versions" bit in
https://github.com/single-cell-data/TileDB-SOMA/actions/runs/10585607673/job/29332572332?pr=2934
is showing even for Python 3.11

Run python scripts/show-versions.py
tiledbsoma.__version__    1.12.0rc0.post106.dev3370075614
tiledb.version()          0.31.1
core version              2.25.0
anndata.__version__  (ad) 0.10.8
numpy.__version__    (np) 1.26.4 <--------------- we are not getting numpy 2.1 installed :(
pandas.__version__   (pd) 2.2.2
pyarrow.__version__  (pa) 17.0.0
scanpy.__version__   (sc) 1.10.2
scipy.__version__    (sp) 1.14.1
python__version__         3.[11](https://github.com/single-cell-data/TileDB-SOMA/actions/runs/10585607673/job/29332572332?pr=2934#step:9:12).9

🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant