[spatial] Add ValueError for mismatched transform names #3062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The transformation argument in the `read_region` is easy to misinterpret. Add an explicit check for the correct `output_axes` in the transform for better error messaging.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## spatial #3062 +/- ##
===========================================
+ Coverage 77.77% 77.83% +0.05%
===========================================
Files 49 49
Lines 5035 5039 +4
===========================================
+ Hits 3916 3922 +6
+ Misses 1119 1117 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nguyenv
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The transformation argument in the
read_regionis easy to misinterpret. Add an explicit check for the correctoutput_axesin the transform for better error messaging.