Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[c++] Fix sanitizer flags and move from an option to a config type #3150

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

jp-dark
Copy link
Collaborator

@jp-dark jp-dark commented Oct 8, 2024

The builds using the SANITIZER option were missing the linker flags necessary to build. This PR adds those back in and moves enabling sanitizers to a config option. The new build types are enabled:

  • ASAN: address sanitizer
  • TSAN: thread sanitizer
  • LSAN: leak sanitizer
  • MSAN: memory sanitizer
  • UBSAN: undefined-behavior sanitizer

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.30%. Comparing base (2875f7d) to head (2366932).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3150      +/-   ##
==========================================
+ Coverage   82.43%   83.30%   +0.87%     
==========================================
  Files          50       51       +1     
  Lines        5209     5458     +249     
==========================================
+ Hits         4294     4547     +253     
+ Misses        915      911       -4     
Flag Coverage Δ
python 83.30% <ø> (+0.87%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 83.30% <ø> (+0.87%) ⬆️
libtiledbsoma ∅ <ø> (∅)

Copy link
Member

@johnkerl johnkerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as the sanitizer is sanitizing

I defer to @nguyenv here ...

Copy link
Member

@johnkerl johnkerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as the sanitizer is sanitizing

I defer to @nguyenv here ...

Copy link
Member

@teo-tsirpanis teo-tsirpanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might have been cleaner if the sanitizer was an option separate from the config, and either accept that it will work only in Debug mode, or enforce it by setting CMAKE_CONFIGURATION_TYPES to only Debug.

libtiledbsoma/cmake/Superbuild.cmake Show resolved Hide resolved
libtiledbsoma/CMakeLists.txt Outdated Show resolved Hide resolved
libtiledbsoma/CMakeLists.txt Show resolved Hide resolved
libtiledbsoma/src/CMakeLists.txt Show resolved Hide resolved
@jp-dark
Copy link
Collaborator Author

jp-dark commented Oct 10, 2024

sc-53780

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants