-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[c++] Fix sanitizer flags and move from an option to a config type #3150
base: main
Are you sure you want to change the base?
Conversation
6880ccf
to
e8ddba3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3150 +/- ##
==========================================
+ Coverage 82.43% 83.30% +0.87%
==========================================
Files 50 51 +1
Lines 5209 5458 +249
==========================================
+ Hits 4294 4547 +253
+ Misses 915 911 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as long as the sanitizer is sanitizing
I defer to @nguyenv here ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as long as the sanitizer is sanitizing
I defer to @nguyenv here ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might have been cleaner if the sanitizer was an option separate from the config, and either accept that it will work only in Debug mode, or enforce it by setting CMAKE_CONFIGURATION_TYPES
to only Debug
.
Co-authored-by: Theodore Tsirpanis <[email protected]>
The builds using the
SANITIZER
option were missing the linker flags necessary to build. This PR adds those back in and moves enabling sanitizers to a config option. The new build types are enabled:ASAN
: address sanitizerTSAN
: thread sanitizerLSAN
: leak sanitizerMSAN
: memory sanitizerUBSAN
: undefined-behavior sanitizer