Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Let registrar provide new shapes for resize #3152

Merged
merged 4 commits into from
Oct 9, 2024

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Oct 9, 2024

Issue and/or context: As tracked on issue #2407 / [sc-51048].

Note that the intended Python and R API changes are all agreed on and finalized as described in #2407.

Changes:

For experiment-level resize and append mode (#3148) we'll need the registrar to offer up the new shapes that the experiment will need to be resized to. This PR supports that goal.

Notes for Reviewer:

This PR is a work in progress. It is not ready for review.

@johnkerl johnkerl changed the base branch from main to kerl/py-can-upgrade-shape October 9, 2024 04:01
@johnkerl johnkerl changed the title [python] Let registrar provide new shapes for resize [skip ci] [python] Let registrar provide new shapes for resize [WIP] Oct 9, 2024
@johnkerl johnkerl changed the title [python] Let registrar provide new shapes for resize [WIP] [python] Let registrar provide new shapes for resize Oct 9, 2024
@johnkerl johnkerl marked this pull request as ready for review October 9, 2024 04:24
Copy link
Collaborator

@jp-dark jp-dark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't look like any tests were added for the get_*_shape == 0 case. Otherwise, looks good to me.

@johnkerl
Copy link
Member Author

johnkerl commented Oct 9, 2024

Thanks @jp-dark -- more to come on #2407! :)

Base automatically changed from kerl/py-can-upgrade-shape to main October 9, 2024 13:51
@johnkerl johnkerl merged commit e80f509 into main Oct 9, 2024
1 check passed
@johnkerl johnkerl deleted the kerl/registration-shape-acceessors branch October 9, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants