Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python/c++] Add SOMAGroup::is_relative and use in pytest unit tests #3166

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

nguyenv
Copy link
Member

@nguyenv nguyenv commented Oct 11, 2024

Issue and/or context:

This is the second of multiple changes pulled out from from #2883 to remove tiledb-py from unit tests

Changes:

  • Add SOMAGroup::is_relative in C++ and associated binding in Pybind11
  • Replace tiledb-py is_relative test with new binding

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.19%. Comparing base (21d9e71) to head (92764fc).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3166   +/-   ##
=======================================
  Coverage   83.19%   83.19%           
=======================================
  Files          51       51           
  Lines        5458     5458           
=======================================
  Hits         4541     4541           
  Misses        917      917           
Flag Coverage Δ
python 83.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 83.19% <ø> (ø)
libtiledbsoma ∅ <ø> (∅)

Copy link
Member

@johnkerl johnkerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nguyenv nguyenv merged commit 57b516e into main Oct 11, 2024
13 of 15 checks passed
@nguyenv nguyenv deleted the viviannguyen/add-is_relative branch October 11, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants