Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Use pathlib.Path.iterdir to count fragments #3168

Merged

Conversation

nguyenv
Copy link
Member

@nguyenv nguyenv commented Oct 11, 2024

Issue and/or context:

This is the fourth of multiple changes pulled out from from #2883 to remove tiledb-py from unit tests

Changes:

Replace tiledb.VFS and tiledb.FragmentInfoList with pathlib.Path.iterdir to count fragments without relying on tiledb-py

Copy link
Member

@johnkerl johnkerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@nguyenv nguyenv force-pushed the viviannguyen/use_iterdir_for_fragment_count_replacement branch from c4cfc41 to 6310907 Compare October 11, 2024 19:59
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.32%. Comparing base (57b516e) to head (6310907).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3168      +/-   ##
==========================================
+ Coverage   83.21%   83.32%   +0.10%     
==========================================
  Files          51       51              
  Lines        5462     5462              
==========================================
+ Hits         4545     4551       +6     
+ Misses        917      911       -6     
Flag Coverage Δ
python 83.32% <ø> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 83.32% <ø> (+0.10%) ⬆️
libtiledbsoma ∅ <ø> (∅)

@nguyenv nguyenv merged commit 176bbf8 into main Oct 11, 2024
11 checks passed
@nguyenv nguyenv deleted the viviannguyen/use_iterdir_for_fragment_count_replacement branch October 11, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants