Correct Gross to Net Generation Bugs #375
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
As I was inspecting the OGE outputs, I noticed some issues with the gross to net generation data that were not fixed by #370. Specifically:
What the code is doing
All of the subplant shift code that was added was previously in the OGE codebase prior to #370. The only new code is l.624-633 in gross_to_net_generation, which explicitly applies this to instances with zero gross generation, rather than applying this in a hierarchy.
Testing
Ran the pipeline for 2018 and examined the logs and outputs
Where to look
It's helpful to clarify where your new code lives if you moved files around or there could be confusion/
What files are most important?
Usage Example/Visuals
How the code can be used and/or images of any graphs, tables or other visuals (not always applicable).
Review estimate
10 min.
Future work
What issues were identified that are not being addressed in this PR but should be addressed in future work?
Checklist
black