Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update data export notebook and small bug fixes #391

Merged
merged 3 commits into from
Oct 4, 2024

Conversation

grgmiller
Copy link
Collaborator

@grgmiller grgmiller commented Oct 4, 2024

Purpose

Updates the notebook used to export generator data for forecasts, and also makes several small bug fixes:

  • In data_pipeline fixes an issue with double quotes in an f-string
  • Updates the function used to fill missing lat/long coordinates to handle additional cases
  • Small changes to visualization function

What the code is doing

See above

Testing

No testing, doesn't affect main pipeline.

Where to look

See files

Usage Example/Visuals

N/A

Review estimate

5 min

Future work

Move the code in the notebook to the forecasts repo.

Checklist

  • Update the documentation to reflect changes made in this PR
  • Format all updated python files using black
  • Clear outputs from all notebooks modified
  • Add docstrings and type hints to any new functions created

@grgmiller grgmiller requested a review from rouille October 4, 2024 16:39
logger.warning(f"ReadTimeoutError for {query}")
return np.NaN, np.NaN
except GeocoderUnavailable:
logger.warning(f"GeocoderUnavailable for {query}")
return np.NaN, np.NaN
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing that.

Copy link
Collaborator

@rouille rouille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@grgmiller grgmiller merged commit 3ea61c5 into development Oct 4, 2024
2 checks passed
@grgmiller grgmiller deleted the export_generator_data branch October 4, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants