Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically change Pages and Registry URL in gh-pages branch #101

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

georgiastuart
Copy link
Contributor

This PR follows #100 and automatically updates the baseurl to the github pages url in the github workflow. This fixes an issue where the stylesheets were not loaded correctly due to a different baseurl.

It was possible to fix this manually, but this solution pulls the github pages URL automatically and replaces it in the config file.

In addition, this PR also automatically swaps the registry URL to the current repository in the gh-pages branch. Again, this was previously a manual step.

Tested in my separate repo georgiastuart/resistry-test (yes there is a typo ;) ) with pages URL here.

georgiastuart and others added 6 commits April 2, 2023 05:37
Update to programatically change baseurl
Signed-off-by: Georgia Stuart <[email protected]>
Signed-off-by: Georgia Stuart <[email protected]>
Signed-off-by: Georgia Stuart <[email protected]>
Signed-off-by: Georgia Stuart <[email protected]>

- name: Set Pages base URL and Registry URL
run: |
URL=$(curl -L \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is some risk here of running this regularly (and having the API response not return successfully, etc.) I want to suggest we add this instruction to the tutorial, to be done once, and it's OK if it's automated like this, or just a manual instruction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants