test: only submit extensions to proposer #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aljo242
commented
Nov 15, 2023
nivasan1
reviewed
Nov 15, 2023
| @@ -733,6 +736,12 @@ func (conR *Reactor) gossipVotesRoutine(peer p2p.Peer, ps *PeerState) { | |||
| // Simple hack to throttle logs upon sleep. | |||
| sleeping := 0 | |||
|
|
|||
| consAddrHexBz, err := hex.DecodeString(string(peer.ID())) | |||
aljo242
force-pushed
the
test/proposer-extentions
branch
from
6e03ea5
to
9d28ebb
Compare
aljo242
commented
Nov 16, 2023
| @@ -2175,7 +2175,12 @@ func (cs *State) addVote(vote *types.Vote, peerID p2p.ID) (added bool, err error | |||
| // Verify VoteExtension if precommit and not nil | |||
| // https://github.com/tendermint/tendermint/issues/8487 | |||
| if vote.Type == cmtproto.PrecommitType && !vote.BlockID.IsZero() && | |||
| !bytes.Equal(vote.ValidatorAddress, myAddr) { // Skip the VerifyVoteExtension call if the vote was issued by this validator. | |||
| !bytes.Equal(vote.ValidatorAddress, myAddr) && | |||
| bytes.Equal(cs.state.NextValidators.Proposer.Address, myAddr) && | |||
There was a problem hiding this comment.
this should be Nextvalidators right?
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
nivasan1
pushed a commit
that referenced
this pull request
Jan 16, 2024
feat: app hash error channel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.