Skip to content

Commit

Permalink
πŸ”₯ Consolidate Neutron and Osmosis Query enum (#53)
Browse files Browse the repository at this point in the history
* πŸ”₯ Consolidate Neutron and Osmosis Query enum

* πŸ“ Add changelog entry
  • Loading branch information
NotJeremyLiu authored Aug 7, 2023
1 parent 0583afe commit 6ae6778
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 20 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ Ref: https://keepachangelog.com/en/1.0.0/

### Minor Improvements
- [#52](https://github.com/skip-mev/skip-api-contracts/pull/52) Ensure Skip package types, methods, and functions are well documented.
- [#53](https://github.com/skip-mev/skip-api-contracts/pull/53) Consolidate Neutron and Osmosis QueryMsg enum's into one enum.

## [v0.2.0](https://github.com/skip-mev/skip-api-contracts/releases/tag/v0.2.0) - 2023-08-03

Expand Down
2 changes: 1 addition & 1 deletion contracts/networks/neutron/ibc-transfer/src/contract.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ use neutron_proto::neutron::transfer::{MsgTransfer, MsgTransferResponse};
use neutron_sdk::sudo::msg::{RequestPacket, TransferSudoMsg};
use prost::Message;
use skip::{
ibc::{AckID, ExecuteMsg, IbcInfo, InstantiateMsg, NeutronQueryMsg as QueryMsg},
ibc::{AckID, ExecuteMsg, IbcInfo, InstantiateMsg, QueryMsg},
proto_coin::ProtoCoin,
sudo::SudoType,
};
Expand Down
5 changes: 1 addition & 4 deletions contracts/networks/osmosis/ibc-transfer/src/contract.rs
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,7 @@ use ibc_proto::ibc::applications::transfer::v1::{MsgTransfer, MsgTransferRespons
use prost::Message;
use serde_cw_value::Value;
use skip::{
ibc::{
AckID, ExecuteMsg, IbcInfo, IbcLifecycleComplete, InstantiateMsg,
OsmosisQueryMsg as QueryMsg,
},
ibc::{AckID, ExecuteMsg, IbcInfo, IbcLifecycleComplete, InstantiateMsg, QueryMsg},
proto_coin::ProtoCoin,
sudo::{OsmosisSudoMsg as SudoMsg, SudoType},
};
Expand Down
17 changes: 2 additions & 15 deletions packages/skip/src/ibc.rs
Original file line number Diff line number Diff line change
Expand Up @@ -34,23 +34,10 @@ pub enum ExecuteMsg {
/// QUERY ///
/////////////

// TODO: Consolidate into one enum now that the return types are the same

// The NeutronQueryMsg enum defines the queries the Neutron IBC Transfer Adapter Contract provides.
#[cw_serde]
#[derive(QueryResponses)]
pub enum NeutronQueryMsg {
#[returns(String)]
InProgressRecoverAddress {
channel_id: String,
sequence_id: u64,
},
}

// The OsmosisQueryMsg enum defines the queries the Osmosis IBC Transfer Adapter Contract provides.
// The QueryMsg enum defines the queries the IBC Transfer Adapter Contract provides.
#[cw_serde]
#[derive(QueryResponses)]
pub enum OsmosisQueryMsg {
pub enum QueryMsg {
#[returns(String)]
InProgressRecoverAddress {
channel_id: String,
Expand Down

0 comments on commit 6ae6778

Please sign in to comment.