Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jl/add swap enum and refund action - STALE #25

Closed
wants to merge 5 commits into from
Closed

Jl/add swap enum and refund action - STALE #25

wants to merge 5 commits into from

Conversation

NotJeremyLiu
Copy link
Member

@NotJeremyLiu NotJeremyLiu commented Jul 25, 2023 •
edited
Loading

This PR:

  • Adds an optional refund_action param to SwapExactCoinOut (to be used if a user swap is swap exact out and needs funds to be sent back)
  • Changes PostSwapAction type to just Action since used in both post_swap_action and refund_action
  • Adds a Swap enum with two variants: SwapExactCoinIn and SwapExactCoinOut
  • Changes user_swap from type SwapExactCoinIn to Swap (does not yet handle the SwapExactCoinOut, a todo and panic is put in place right now)

@NotJeremyLiu NotJeremyLiu mentioned this pull request Jul 25, 2023
Closed
6 tasks
@NotJeremyLiu NotJeremyLiu marked this pull request as draft July 28, 2023 20:37
@NotJeremyLiu NotJeremyLiu changed the title Jl/add swap enum and refund action Jl/add swap enum and refund action - STALE Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@NotJeremyLiu