⚡️ Derive user swap coin in from remaining coin received only #31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
coin_in
inuser_swap
that was less than theremaining_coin_received
on contract.coin_in
inuser_swap
was the exact same as theremaining_coin_received
, otherwise it errors. So it no longer makes sense to accept acoin_in
parameter if all it does is open up a vector for a user error that errors the transaction.This PR
coin_in
field in theSwapExactCoinIn
typecoin_in
field, instead just usingremaining_coin_received