⚡️ Derive Fee Swap Coin Out From IBC Fees Provided #36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
coin_out
param inSwapExactCoinOut
, but the logic would essentially ensure thiscoin_out
provided matched the actual fees given inibc_info.fee
.coin_out
is directly derived from the provided ibc fees itself, leaving no way for the caller to specify an incorrectcoin_out
.This PR
coin_out
field fromSwapExactCoinOut
one_coin
method on IbcFee to ensure that if it provided it is exactly one coin (since the rest of the contract can't handle multiple ibc fee swaps anyways, and since it's an Option it should be set to None if no ibc fees are required)