Skip to content

Commit

Permalink
Changelog entry, references to the GH PR
Browse files Browse the repository at this point in the history
  • Loading branch information
BenjaminBossan committed Aug 15, 2023
1 parent 34dbcc6 commit fa94bf7
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 1 deletion.
2 changes: 2 additions & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Changed
### Fixed

- Fixed a couple of issues when saving and loading parameters while using accelerate (via `AccelerateMixin`) in a multi-GPU setting (#1008)

## [0.14.0] - 2023-06-24

### Added
Expand Down
2 changes: 1 addition & 1 deletion examples/accelerate-multigpu/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ use_cpu: false
## `run-save-load.py`

The context of this script is that there were issues with saving and loading when using `AccelerateMixin`. The provided script is to ensure that everything works as expected. Same as the first one, for a proper test, this script needs to run in a multi-GPU setting.
The context of this script is that there were issues with saving and loading when using `AccelerateMixin`. The provided script is to ensure that everything works as expected. Same as the first one, for a proper test, this script needs to run in a multi-GPU setting. For more information, check PR #1008.

Run the scripts like this:

Expand Down
2 changes: 2 additions & 0 deletions skorch/tests/test_hf.py
Original file line number Diff line number Diff line change
Expand Up @@ -688,6 +688,8 @@ def test_save_load_params(
# Note that we cannot really test this with unit tests because it
# requires a multi-GPU setup. To run a proper test, please run the
# `run-save-load.py` script in skorch/examples/accelerate-multi-gpu/.

# More context in PR #1008
accelerator = accelerator_cls()

def get_accelerate_net():
Expand Down

0 comments on commit fa94bf7

Please sign in to comment.