Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accelerate bug in specific versions #1007

Merged
merged 3 commits into from
Aug 28, 2023
Merged

Accelerate bug in specific versions #1007

merged 3 commits into from
Aug 28, 2023

Commits on Aug 14, 2023

  1. Exclude accelerate versions with unwrap_model bug 

    In versions 0.20.* and 0.21.0 (latest), there was/is a bug in
unwrap_model with keep_fp32_wrapper=False. This results in forward not
working after unwrapping the model, which can affect skorch users who
use AccelerateMixin.

The bug has been fixed in this PR:

huggingface/accelerate#1838

However, there was no release yet. Therefore, I exclude the specific
accelerate versions with that bug. Using a version <0.20 or a later
release should work.

To catch this type of issue sooner, I added a test that will trigger the
bug.
    @BenjaminBossan
    BenjaminBossan committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    0236131 View commit details
    Browse the repository at this point in the history

  2. Be more precise about the versions

    @BenjaminBossan
    BenjaminBossan committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    941ea5e View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2023

  1. Use accelerate>=0.22.0

    @BenjaminBossan
    BenjaminBossan committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    8a27860 View commit details
    Browse the repository at this point in the history