Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python 3.8, add Python 3.12 #1070

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/testing.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
strategy:
fail-fast: false # don't cancel all jobs when one fails
matrix:
python_version: ['3.8', '3.9', '3.10', '3.11']
python_version: ['3.9', '3.10', '3.11', '3.12']
torch_version: ['2.1.2+cpu', '2.2.2+cpu', '2.3.1+cpu', '2.4.0+cpu']
os: [ubuntu-latest]

Expand Down
2 changes: 1 addition & 1 deletion README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ skorch also provides many convenient features, among others:
Installation
============

skorch requires Python 3.8 or higher.
skorch requires Python 3.9 or higher.

conda installation
==================
Expand Down
2 changes: 1 addition & 1 deletion docs/user/installation.rst
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ If you want to help developing, run:
pylint skorch # static code checks

You may adjust the Python version to any of the supported Python versions, i.e.
Python 3.8 or higher.
Python 3.9 or higher.

Using pip
^^^^^^^^^
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
tests_require = [l.strip() for l in f]


python_requires = '>=3.8'
python_requires = '>=3.9'

docs_require = [
'Sphinx',
Expand Down
Loading