Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Bagging ensemble of probabilistic regressors #32

Merged
merged 26 commits into from
Sep 13, 2023
Merged

[ENH] Bagging ensemble of probabilistic regressors #32

merged 26 commits into from
Sep 13, 2023

Conversation

fkiraly
Copy link
Collaborator

@fkiraly fkiraly commented Aug 25, 2023

Adds bagging ensemble of probabilistic regressors.

Complete rewrite of the legacy estimator.

Depends on:

@fkiraly fkiraly added enhancement module:regression probabilistic regression module implementing algorithms Implementing algorithms, estimators, objects native to skpro labels Aug 25, 2023
@fkiraly
Copy link
Collaborator Author

fkiraly commented Aug 26, 2023

predict_quantiles takes long to run since ppf is computed by bisection, in the mixture. Should probably try to tweak the bisection parameters (higher tolerance, less max iterations etc) to ensure shorter runtime.

@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.65% 🎉

Comparison is base (0d8bd68) 70.91% compared to head (a8dc486) 71.57%.
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #32      +/-   ##
==========================================
+ Coverage   70.91%   71.57%   +0.65%     
==========================================
  Files          93       93              
  Lines        4962     5016      +54     
  Branches      900      903       +3     
==========================================
+ Hits         3519     3590      +71     
+ Misses       1205     1189      -16     
+ Partials      238      237       -1     
Files Changed Coverage Δ
skpro/regression/base/_base.py 65.40% <100.00%> (+1.07%) ⬆️
skpro/regression/ensemble.py 100.00% <100.00%> (+55.17%) ⬆️
skpro/regression/tests/test_all_regressors.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fkiraly fkiraly merged commit 945966e into main Sep 13, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement implementing algorithms Implementing algorithms, estimators, objects native to skpro module:regression probabilistic regression module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants