Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] fix distribution suite test class missing package config #34

Merged
merged 1 commit into from
Aug 25, 2023
Merged

[BUG] fix distribution suite test class missing package config #34

merged 1 commit into from
Aug 25, 2023

Conversation

fkiraly
Copy link
Collaborator

@fkiraly fkiraly commented Aug 25, 2023

The distribution suite test class TestAllDistributions did not test any of the distributions in skpro, as the PackageConfig configuration was not present by inheritance.

This is now fixed, so all distributions are properly tested.

@fkiraly fkiraly added bug maintenance Continuous integration, unit testing & package distribution module:base-framework BaseObject, registry, base framework labels Aug 25, 2023
@fkiraly fkiraly mentioned this pull request Aug 25, 2023
Closed
@fkiraly fkiraly merged commit 798615d into main Aug 25, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug maintenance Continuous integration, unit testing & package distribution module:base-framework BaseObject, registry, base framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fkiraly