-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Conjugate bayes for proportion #417
Draft
meraldoantonio
wants to merge
14
commits into
sktime:main
Choose a base branch
from
meraldoantonio:conjugate_bayes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
meraldoantonio
changed the title
[ENH] Conjugate bayes for proprtion
[ENH] Conjugate bayes for proportion
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
This relates to the WIP of design of Bayesian blueprint #35
What does this implement/fix? Explain your changes.
This PR implements the BayesianProportionEstimator, a new estimator for estimating proportions using Bayesian inference with a Beta prior. It includes a notebook demonstrating how to use the estimator with a coin toss example, showing how to update prior beliefs with observed data and visualize the posterior distribution.
Does your contribution introduce a new dependency? If yes, which one?
Yes, matplotlib (for plotting).
What should a reviewer concentrate their feedback on?
Certainly! Here’s the improved version of the text:
The implementation of the BayesianProportionEstimator class should be reviewed for its alignment with the WIP Bayesian blueprint #35. Additionally, please evaluate the clarity and completeness of the accompanying notebook example.
It is important to note that the BayesianProportionEstimator is not a traditional regressor. Instead, during fitting, it takes as input an array of Booleans or 1's and 0's representing the success of a series of experiments.
Due to its specialized nature, the estimator is not suitable for tests designed to validate regression functionality, and it may fail such tests.
Maybe we should put this estimator in its own folder.
Did you add any tests for the change?
No
Any other comments?
No
PR checklist
For all contributions
How to: add yourself to the all-contributors file in the
skpro
root directory (not theCONTRIBUTORS.md
). Common badges:code
- fixing a bug, or adding code logic.doc
- writing or improving documentation or docstrings.bug
- reporting or diagnosing a bug (get this pluscode
if you also fixed the bug in the PR).maintenance
- CI, test framework, release.See here for full badge reference
For new estimators
docs/source/api_reference/taskname.rst
, follow the pattern.Examples
section.python_dependencies
tag and ensureddependency isolation, see the estimator dependencies guide.