Fix BrightnessSlider transparent background #47
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a thorough refactoring of the BrightnessSlider somewhere after release 1.0.4, the slider background would falsely show a gradient going from full transparency to zero transparency:
This commit removes the alpha logic and replaces it with the previously used shader going from pure black to the (pure) selected colour. The previous logic, for reference:
colorpicker-compose/colorpicker-compose/src/main/kotlin/com/github/skydoves/colorpicker/compose/BrightnessSlider.kt
Lines 172 to 177 in 0320c67
Fixes #42