-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OCI] Support OCI Object Storage #4501
Open
HysunHe
wants to merge
17
commits into
skypilot-org:master
Choose a base branch
from
HysunHe:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+759
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Michaelvll @cblmemo Hi Zhanghao & Tianxia, Ask for your support to review/someone else to review the PR. Thanks. |
cblmemo
reviewed
Dec 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this amazing work @HysunHe ! Left some discussions :))
@cblmemo Thanks for the prompt review. All points are addressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the implementation of the OCI Object Storage store (Re-submit).
It is an usually solid requirement for those using SkyPilot with OCI, otherwise user has to enable other supported cloud (with buckets) to leverage its cloud storage for data sync, for example, sky serve require cloud storage to sync workdir.
Actually I have implemented and used the OCI Object Storage with SkyPilot quite a long time (mainly for POC projects), now submit the PR to merge the code to the repo because there are requirements from other users.
For documentation to add OCI store, we can do it later after this PR.
sky launch -y -c smoke_test --cloud oci --num-nodes 2 examples/oci/oci-mounts.yaml
Tested (run the relevant ones):
bash format.sh
pytest tests/test_smoke.py
pytest tests/test_smoke.py::test_oci_mounts
conda deactivate; bash -i tests/backward_compatibility_tests.sh