Fix insertContents for prepending block embeds #3842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luin
force-pushed
the
zh-insertcontents-blockembed
branch
from
11f46f1
to
3f90b0d
Compare
luin
force-pushed
the
zh-insertcontents-blockembed
branch
from
3f90b0d
to
47515f5
Compare
jhchen
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug when the delta passed to
insertContentsstarts with a block embed: The attributes of the block embed were not applied becauseinsertContentscalledformatAtagainst a wrong index.This PR fixed the issue. Added a test case and also fixed an issue where in fuzz tests, we didn't generate a random doc whose first blot was block embed.