-
Notifications
You must be signed in to change notification settings - Fork 833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix base url according to official documentation #1485
Conversation
Thanks for the contribution! Before we can merge this, we need @AyumuKasuga to sign the Salesforce Inc. Contributor License Agreement. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @AyumuKasuga thanks for the contribution 💯
It does appear like our other SDKs also use https://slack.com/api/
- here in the node sdk
- I could not find a reference to www.slack.com in the java client
@seratch let me know if you have any idea why www.
was used here
Thanks for the suggestion! Indeed, this can be consistent across the SDKs. I am fine to have this change too, but I would like to hold off merging it until the timing we release a new "minor" version, not a patch one. Some existing users may have proxy rules etc. that relies on www. domain URL. Having this type of change in a patch version coul be a surprising behavior change. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1485 +/- ##
=======================================
Coverage 85.08% 85.09%
=======================================
Files 112 112
Lines 12320 12320
=======================================
+ Hits 10483 10484 +1
+ Misses 1837 1836 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
In the official documentation there is only mention of the
slack.com
domain (notwww.slack.com
), for example here or here. I think we should have the same domain in the sdk as well for the consistency.Category (place an
x
in each of the[ ]
)/docs-src
(Documents, have you run./scripts/docs.sh
?)/docs-src-v2
(Documents, have you run./scripts/docs-v2.sh
?)/tutorial
(PythOnBoardingBot tutorial)tests
/integration_tests
(Automated tests for this library)Requirements (place an
x
in each[ ]
)python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh
after making the changes.