Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add deprecation warnings to Steps from Apps methods #1504

Merged

Conversation

WilliamBergamin
Copy link
Contributor

Summary

This PR aims to add a deprecation warning for methods that related to legacy workflows

Here is an example of the warning

UserWarning: workflows.updateStep is deprecated. For more info, go to https://api.slack.com/changelog/2023-08-workflow-steps-from-apps-step-back

Category

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs-src (Documents, have you run ./scripts/docs.sh?)
  • /docs-src-v2 (Documents, have you run ./scripts/docs-v2.sh?)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

Copy link

codecov bot commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 85.09%. Comparing base (7d13c3b) to head (5aeec15).

Files Patch % Lines
slack_sdk/web/deprecation.py 20.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1504      +/-   ##
==========================================
- Coverage   85.11%   85.09%   -0.02%     
==========================================
  Files         112      112              
  Lines       12315    12320       +5     
==========================================
+ Hits        10482    10484       +2     
- Misses       1833     1836       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WilliamBergamin WilliamBergamin merged commit 5f941f4 into slackapi:main Jun 7, 2024
11 of 12 checks passed
@WilliamBergamin WilliamBergamin deleted the steps-from-apps-deprecation branch June 7, 2024 13:16
@WilliamBergamin WilliamBergamin added this to the 3.28.0 milestone Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants