Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump io.zipkin.reporter2:zipkin-sender-urlconnection from 2.17.2 to 3.0.0 #1106

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 7, 2024

Bumps io.zipkin.reporter2:zipkin-sender-urlconnection from 2.17.2 to 3.0.0.

Release notes

Sourced from io.zipkin.reporter2:zipkin-sender-urlconnection's releases.

Zipkin Reporter 3.0.0 makes the io.zipkin.zipkin2:zipkin dependency of io.zipkin.reporter2:zipkin-reporter-brave optional. This means those using the AsyncZipkinSpanHandler will have no dependencies except any sender they configure. In particular, this allows those using Brave for things besides zipkin (e.g. wavefront) to avoid a dependency. Also, those sending spans zipkin have simpler dependency configuration and save a couple hundred KB, as well.

Those using types from the core io.zipkin.reporter2:zipkin-reporter artifact should depend on this directly, possibly using our bom to align deps. io.zipkin.reporter2:zipkin-reporter still defaults to depend on io.zipkin.zipkin2:zipkin, but it can be excluded if you know what you are doing.

Technically, some base classes to accommodate this, but they don't have affect on call sites except those implementing a custom Reporter or Sender. Due to these type changes, this is a major version change. However, must users will have a drop-in experience, except possibly dependency configuration changes.

Thanks a lot to @​anuraaga and @​reta who helped think through this!

Changelog

Sourced from io.zipkin.reporter2:zipkin-sender-urlconnection's changelog.

OpenZipkin Release Process

This repo uses semantic versions. Please keep this in mind when choosing version numbers.

  1. Alert others you are releasing

    There should be no commits made to master while the release is in progress (about 10 minutes). Before you start a release, alert others on gitter so that they don't accidentally merge anything. If they do, and the build fails because of that, you'll have to recreate the release tag described below.

  2. Push a git tag

    The trigger format is release-MAJOR.MINOR.PATCH, ex git tag release-1.18.1 && git push origin release-1.18.1.

  3. Wait for CI

    The release-MAJOR.MINOR.PATCH tag triggers https://github.com/openzipkin/zipkin-reporter-java/blob/3.0.0/build-bin/maven/maven_release, which creates commits, MAJOR.MINOR.PATCH tag, and increments the version (maven-release-plugin).

    The MAJOR.MINOR.PATCH tag triggers https://github.com/openzipkin/zipkin-reporter-java/blob/3.0.0/build-bin/deploy, which does the following:

    Notes:

Credentials

The release process uses various credentials. If you notice something failing due to unauthorized, look at the notes in [.github/workflows/deploy.yml] and check the org secrets.

Troubleshooting invalid credentials

If you receive a '401 unauthorized' failure from OSSRH, it is likely SONATYPE_USER or SONATYPE_PASSWORD entries are invalid, or possibly the user associated with them does not have rights to upload.

The least destructive test is to try to publish a snapshot manually. By passing the values CI would use, you can kick off a snapshot from your laptop. This is a good way to validate that your unencrypted credentials are authorized.

Here's an example of a snapshot deploy with specified credentials.

$ export GPG_TTY=$(tty) && GPG_PASSPHRASE=whackamole SONATYPE_USER=adrianmole SONATYPE_PASSWORD=ed6f20bde9123bbb2312b221 build-bin/build-bin/maven/maven_deploy

First release of the year

The license plugin verifies license headers of files include a copyright notice indicating the years a file was affected. This information is taken from git history. There's a once-a-year problem with files that include version numbers (pom.xml).

... (truncated)

Commits
  • 0bca54d [maven-release-plugin] prepare release 3.0.0
  • c05b82c Decouples from io.zipkin.zipkin2:zipkin (#234)
  • ca6aa21 [maven-release-plugin] prepare for next development iteration
  • See full diff in compare view

Most Recent Ignore Conditions Applied to This Pull Request
Dependency Name Ignore Conditions
io.zipkin.reporter2:zipkin-sender-urlconnection [>= 3.a, < 4]

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Oct 7, 2024
@dependabot dependabot bot force-pushed the dependabot/maven/io.zipkin.reporter2-zipkin-sender-urlconnection-3.0.0 branch 7 times, most recently from df013e1 to 0847499 Compare October 7, 2024 22:50
Bumps [io.zipkin.reporter2:zipkin-sender-urlconnection](https://github.com/openzipkin/zipkin-reporter-java) from 2.17.2 to 3.0.0.
- [Release notes](https://github.com/openzipkin/zipkin-reporter-java/releases)
- [Changelog](https://github.com/openzipkin/zipkin-reporter-java/blob/3.0.0/RELEASE.md)
- [Commits](openzipkin/zipkin-reporter-java@2.17.2...3.0.0)

---
updated-dependencies:
- dependency-name: io.zipkin.reporter2:zipkin-sender-urlconnection
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/maven/io.zipkin.reporter2-zipkin-sender-urlconnection-3.0.0 branch from 0847499 to 326858e Compare October 8, 2024 00:06
@bryanlb
Copy link
Contributor

bryanlb commented Oct 8, 2024

@dependabot ignore this major version

@dependabot dependabot bot closed this Oct 8, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 8, 2024

OK, I won't notify you about version 3.x.x again, unless you re-open this PR.

@dependabot dependabot bot deleted the dependabot/maven/io.zipkin.reporter2-zipkin-sender-urlconnection-3.0.0 branch October 8, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant