Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ensureSingleBuffer in slave class #965

Merged
merged 2 commits into from
Aug 10, 2023
Merged

Conversation

slacrherbst
Copy link
Contributor

@slacrherbst slacrherbst commented Aug 9, 2023

The ensureSingleBuffer call exists in the stream Master. But the documentation infers, correctly, that it can and should be used in the Slave as well. This adds a slave specific version in the Slave class.

This also adds a more meaningful call to allocate a frame inside a Slave from the local Slave pool: reqLocalFrame()

@codecov-commenter
Copy link

Codecov Report

Merging #965 (f7ee6e9) into pre-release (761c5c2) will not change coverage.
Report is 4 commits behind head on pre-release.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff              @@
##           pre-release     #965   +/-   ##
============================================
  Coverage        29.89%   29.89%           
============================================
  Files               65       65           
  Lines             6624     6624           
  Branches          1013     1013           
============================================
  Hits              1980     1980           
  Misses            4488     4488           
  Partials           156      156           

@slacrherbst slacrherbst merged commit cf617fb into pre-release Aug 10, 2023
5 checks passed
@slacrherbst slacrherbst deleted the ensure_single branch August 10, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants